Switch to expose FeeRate::from_sat_per_vb_u32 in bindings#891
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Apr 27, 2026
Merged
Conversation
Previously, we exposed the `FeeRate::from_sat_per_vb_unchecked` constructor, which however was now marked deprecated with `bitcoin-units` v0.1.3 (see https://docs.rs/bitcoin-units/0.1.3/bitcoin_units/fee_rate/struct.FeeRate.html#method.from_sat_per_vb_unchecked). Here, we switch to `from_sat_per_vb_u32`, also fixing our CI job that started to fail on the deprecation warning.
|
👋 Thanks for assigning @jkczyz as a reviewer! |
jkczyz
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we exposed the
FeeRate::from_sat_per_vb_uncheckedconstructor, which however was now marked deprecated withbitcoin-unitsv0.1.3 (seehttps://docs.rs/bitcoin-units/0.1.3/bitcoin_units/fee_rate/struct.FeeRate.html#method.from_sat_per_vb_unchecked).
Here, we switch to
from_sat_per_vb_u32, also fixing our CI job that started to fail on the deprecation warning.